Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: ddtrace/tracer: enable B3 propagation without environment variables #1144

Closed
knusbaum opened this issue Jan 24, 2022 · 0 comments · Fixed by #1148
Closed

proposal: ddtrace/tracer: enable B3 propagation without environment variables #1144

knusbaum opened this issue Jan 24, 2022 · 0 comments · Fixed by #1148
Labels
ack proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@knusbaum
Copy link
Contributor

Answer for customer:

In order to enable B3 headers without using environment variables, I propose that we add a new field to PropagatorConfig called B3 which would be a boolean value that you could set to true and enable support for B3.

Then, you could do something like the below:

p := tracer.NewPropagator(&PropagatorConfig{B3: true})
@knusbaum knusbaum added proposal more in depth change that requires full team approval proposal/accepted Accepted proposals ack labels Jan 24, 2022
ajgajg1134 added a commit that referenced this issue Jan 27, 2022
@ajgajg1134
ddtrace/tracer: Add B3 flag to PropagatorConfig
973e296 
The new B3 flag allows a user to add B3 header propagation without an environment variable.

Fixes #1144
@ajgajg1134 ajgajg1134 mentioned this issue Jan 27, 2022
Merged
ajgajg1134 added a commit that referenced this issue Jan 28, 2022
@ajgajg1134
ddtrace/tracer: Add B3 flag to PropagatorConfig (#1148)
f985744 
The new B3 flag allows a user to add B3 header propagation without an environment variable.

Fixes #1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ack proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddtrace/tracer: Add B3 flag to PropagatorConfig DataDog/dd-trace-go
1 participant
@knusbaum