Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/aws/aws-sdk-go: Add WithErrorCheck option #1664

Closed
soh335 opened this issue Jan 16, 2023 · 5 comments
Closed

contrib/aws/aws-sdk-go: Add WithErrorCheck option #1664

soh335 opened this issue Jan 16, 2023 · 5 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@soh335
Copy link
Contributor

soh335 commented Jan 16, 2023

Same feature with #1315.
Sometime, we want to ignore known aws error.

For example, It is dynamodb case. Some data are stored in dynamodb, and it is split by time for scaling (like this).
And program request data with range, and some queries are failed with "ResourceNotFoundException", because table is not exist.
But it is expected error for program, so we think not need to mark error in datadog.

But current aws wrapper records all error, so many error is shown in datadog.
So We want to add WithErrorCheck option.

@soh335 soh335 added the enhancement quick change/addition that does not need full team approval label Jan 16, 2023
@katiehockman katiehockman added the apm:ecosystem contrib/* related feature requests or bugs label Feb 9, 2023
@amwill04
Copy link

amwill04 commented Apr 6, 2023

Are PR accepted? For another example: checking if a file exists on S3 is polluting datadog with NotFound errors which as OP states is a known/wanted error.

@soh335
Copy link
Contributor Author

soh335 commented Apr 6, 2023

I'm happy if this p-r is merged !

@ajgajg1134 ajgajg1134 added the proposal more in depth change that requires full team approval label Apr 6, 2023
@ajgajg1134 ajgajg1134 added the proposal/accepted Accepted proposals label Apr 19, 2023
@ajgajg1134
Copy link
Contributor

Thanks for the contribution, we'll take a look at the PR shortly

@rodrigoff
Copy link
Contributor

Any news on this? I also have a use case for this when using conditional check on DynamoDB.

@katiehockman
Copy link
Contributor

It looks like this has been completed in #2042 and #1682 😄 I'll go ahead and close this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants