contrib/aws-sdk-go: add WithErrorCheck for aws sdk (v1 & v2) #1870
+55
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianashevchenko
requested changes
Apr 20, 2023
|
@amwill04 it looks like this has actually already been completed and merged here: #2042 and #1682 When I resolved the merge conflicts, only test changes remained. Are we good to close this PR then? Thanks for contributing it regardless, and apologies for the delay and back and forth. Glad to see the feature is already supported though 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
WithErrorCheckoption toawsso an error can be determined if it should be marked as an error or not. Been added to bothcontrib/aws-sdk-goandcontrib/aws-sdk-go-v2Closes #1664. Code is taken from #1315