Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: enable configuring of AWS SDK Go v2 through config.LoadOptionsFunc #2094

Open
dcarbone opened this issue Jul 5, 2023 · 2 comments
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval

Comments

@dcarbone
Copy link

dcarbone commented Jul 5, 2023

I have a scenario where it would be prefrable to be able to apply the DataDog tracing middleware through the use of a config.LoadOptionsFunc that can be provided to the config.LoadDefaultConfig func.

I will have a PR with an intial pass at this work inbound shortly.

@dcarbone dcarbone added the enhancement quick change/addition that does not need full team approval label Jul 5, 2023
dcarbone added a commit to dcarbone/dd-trace-go that referenced this issue Jul 5, 2023
dcarbone added a commit to dcarbone/dd-trace-go that referenced this issue Jul 5, 2023
dcarbone added a commit to dcarbone/dd-trace-go that referenced this issue Jul 5, 2023
@rarguelloF rarguelloF added the apm:ecosystem contrib/* related feature requests or bugs label Jul 31, 2023
@rarguelloF
Copy link
Contributor

Hi @dcarbone 👋 and thanks for opening this issue.

While we take a closer look at your proposal and PR, could you please provide us more context on why the existing AppendMiddleware doesn't fit in your use-case? (having some code example would be great to better understand the problem).

@knusbaum knusbaum changed the title Enable configuring of AWS SDK Go v2 through config.LoadOptionsFunc proposal: enable configuring of AWS SDK Go v2 through config.LoadOptionsFunc Aug 3, 2023
@knusbaum knusbaum added proposal more in depth change that requires full team approval waiting-for-info waiting for answer from issue creator labels Aug 3, 2023
@dcarbone
Copy link
Author

dcarbone commented Aug 4, 2023

This is a more idiomatic way of adding config options.

Why pass the entire config object to you? You don't need to know / care about the actual conf instance itself. All you need is to provide a function that complies with the LoadOptionsFunc signature defined by the upstream aws config package and be done with it.

dcarbone added a commit to dcarbone/dd-trace-go that referenced this issue Aug 4, 2023
@ajgajg1134 ajgajg1134 added proposal/accepted Accepted proposals and removed waiting-for-info waiting for answer from issue creator labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs enhancement quick change/addition that does not need full team approval proposal/accepted Accepted proposals proposal more in depth change that requires full team approval
Projects
None yet
Development

No branches or pull requests

4 participants