Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/go-redis/redis.v8: support go-redis.v8 #727

Merged
merged 4 commits into from
Oct 5, 2020

Conversation

sfroment
Copy link
Contributor

@sfroment sfroment commented Sep 9, 2020

This is simply a port of contrib/go-redis/redis, but for go-redis.v8 with the new Hook mechanism.

@sfroment sfroment force-pushed the dev/sfroment/support-redis.v8 branch 2 times, most recently from 758084e to cb69061 Compare September 11, 2020 07:55
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I only have a few comments.

contrib/go-redis/redis.v8/option.go Outdated Show resolved Hide resolved
contrib/go-redis/redis.v8/redis.go Outdated Show resolved Hide resolved
contrib/go-redis/redis.v8/redis.go Outdated Show resolved Hide resolved
@sfroment
Copy link
Contributor Author

sfroment commented Sep 23, 2020

Sorry for the delay updated the PR, do not hesitate if there is anything else that need to me done :)

knusbaum
knusbaum previously approved these changes Sep 28, 2020
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @sfroment

@knusbaum knusbaum added this to the 1.28.0 milestone Sep 28, 2020
contrib/go-redis/redis.v8/redis.go Outdated Show resolved Hide resolved
@sfroment sfroment force-pushed the dev/sfroment/support-redis.v8 branch 2 times, most recently from 3bfa039 to 7371572 Compare October 2, 2020 07:50
@sfroment sfroment requested a review from knusbaum October 2, 2020 07:55
knusbaum
knusbaum previously approved these changes Oct 2, 2020
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks.

@sfroment Since v1.27.0 was released, the PR needs to be rebased on v1 in order to get the tests to pass.
I am happy to rebase this for you if you don't have time.

Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
* add interface validation at compile time
* remove useless helper func

Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
Signed-off-by: sacha-froment-ext <sfroment42@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants