Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.31.0 is missing in tags #929

Closed
mfechner opened this issue May 19, 2021 · 6 comments
Closed

Version 1.31.0 is missing in tags #929

mfechner opened this issue May 19, 2021 · 6 comments

Comments

@mfechner
Copy link

Dear all,

FreeBSD depends for go modules on tags hosted on github.
It seems that the go modules was released here:
https://pkg.go.dev/gopkg.in/DataDog/dd-trace-go.v1@v1.31.0

But not on github.

To be able to build packages using version 1.31.0 FreeBSD (freebsd.org) requires the package to be existing on github.

Is it possible to add the missing tag?

Thanks a lot.

@felixge
Copy link
Member

felixge commented May 21, 2021

cc @knusbaum @gbbr I can add the tag, should I? Or was 1.31.0 released to go.pkg.dev by accident?

@wouafff
Copy link

wouafff commented May 21, 2021

+1

@gbbr
Copy link
Contributor

gbbr commented May 24, 2021

We will be releasing v1.31.0 next, and then it should be fine. Not exactly sure how this happened...

@dmitshur
Copy link

dmitshur commented May 24, 2021

Not exactly sure how this happened...

What I wrote in golang/go#46348 (comment) may be relevant.

Perhaps PR #910 and issue #911 are also relevant, since there are mentions of v1.31.0 in them, and their dates are close to the index date.

We will be releasing v1.31.0 next, and then it should be fine.

Please be mindful that if v1.31.0 was published previously and its tag was deleted, there may be checksum entries for that version in some user's go.sum files and in the checksum database (https://sum.golang.org/), so if v1.31.0 is published with a different content, it will have a non-matching checkum. (If it's pushed with the same content, the checksum will match.)

It would be very safe to publish a new, higher version like v1.31.1 or v1.32.0, which would become the new "latest" stable release version (and can be used instead of v1.31.0).

Module retraction may also be relevant here, since it might be easier to just skip this version and move forward.

@gbbr
Copy link
Contributor

gbbr commented May 25, 2021

Thanks for jumping in here @dmitshur. I'd suggest that probably the best solution here would be to go for v1.31.1 as a "patch" for the bad tag incident.

@knusbaum
Copy link
Contributor

Version v1.31.1 has just been published, so this should be fixed. Version v1.31.0 is still not available, but any future go get gopkg.in/DataDog/dd-trace-go.v1 should get the later version, not the bad v1.31.0 version.

Sorry for the inconvenience.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue May 29, 2021
Required for gitlab-ce 13.12.
The port was removed from deps of gitlab-ce as it is currently not buildable.
Reason is, we have deps that are not existing.
It was reported here:
DataDog/dd-trace-go#929
https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent/-/issues/125

The moment it is fixed upstream, port is again added as dep to gitlab-ce.
evadot pushed a commit to evadot/freebsd-ports that referenced this issue Jun 2, 2021
Required for gitlab-ce 13.12.
The port was removed from deps of gitlab-ce as it is currently not buildable.
Reason is, we have deps that are not existing.
It was reported here:
DataDog/dd-trace-go#929
https://gitlab.com/gitlab-org/cluster-integration/gitlab-agent/-/issues/125

The moment it is fixed upstream, port is again added as dep to gitlab-ce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants