profiler: Add WithDeltaProfiles() option #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delta profiles require a certain amount of heap memory that is proportional to MemStats.BuckHashSys (typically ~2x). For applications that make heavy use of code generation or recursion the memory usage can be several hundred MB. Add WithDeltaProfiles() that allows to disable delta profiles for applications where this is a deal breaker. Those applications will still see allocation profiles, but they won't be able to aggregate or compare them. The default value for WithDeltaProfiles() is true since applications with high BuckHashSys seem to be rare. See https://dtdg.co/go-delta-profile-docs for more information about delta profiles. Mitigates #1025 and implements PROF-4305.
|
Todo after this gets merged:
|
gbbr
approved these changes
Nov 1, 2021
This was referenced Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delta profiles require a certain amount of heap memory that is
proportional to MemStats.BuckHashSys (typically ~2x). For applications
that make heavy use of code generation or recursion this memory usage can
be several hundred MB.
Add WithDeltaProfiles() that allows to disable delta profiles for
applications where this is a deal breaker. Those applications will still
see allocation profiles, but they won't be able to aggregate or compare
them.
The default value for WithDeltaProfiles() is true since applications
with high BuckHashSys seem to be rare.
See https://dtdg.co/go-delta-profile-docs for more information about
delta profiles.
Mitigates #1025 and implements PROF-4305.