Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/labstack/echo.v4: add appsec integration #1042

Merged
merged 15 commits into from
Dec 6, 2021
Merged

contrib/labstack/echo.v4: add appsec integration #1042

merged 15 commits into from
Dec 6, 2021

Conversation

Julio-Guerra
Copy link
Contributor

Enable AppSec in echo.v4 by including the AppSec HTTP instrumentation in
the echo middleware function.

contrib/labstack/echo.v4: add appsec integration
0e3aa23 
Enable AppSec in echo.v4 by including the AppSec HTTP instrumentation in
the echo middleware function.
@Julio-Guerra Julio-Guerra added this to the 1.35.0 milestone Nov 4, 2021
gbbr
gbbr suggested changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few thoughts.

internal/appsec/dyngo/instrumentation/httpinstr/http.go Show resolved Hide resolved
contrib/labstack/echo.v4/echotrace.go Outdated Show resolved Hide resolved
internal/appsec/dyngo/instrumentation/httpinstr/http.go Outdated Show resolved Hide resolved
internal/appsec/dyngo/instrumentation/httpinstr/http.go Outdated Show resolved Hide resolved
internal/appsec/dyngo/instrumentation/httpinstr/http.go Show resolved Hide resolved
contrib/labstack/echo.v4/echotrace.go Outdated Show resolved Hide resolved
gbbr
gbbr reviewed Nov 25, 2021
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Julio. A few more nits.

ddtrace/tracer/log.go Outdated Show resolved Hide resolved
internal/appsec/appsec.go Outdated Show resolved Hide resolved
contrib/labstack/echo.v4/echotrace.go Outdated Show resolved Hide resolved
contrib/internal/httputil/trace.go Outdated Show resolved Hide resolved
gbbr
gbbr previously approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Julio! This looks fine by me. If you want to wait for an additional review from @knusbaum, please do that.

contrib/internal/httputil/trace.go Outdated Show resolved Hide resolved
knusbaum
knusbaum previously approved these changes Dec 6, 2021
View reviewed changes
@Julio-Guerra Julio-Guerra dismissed stale reviews from knusbaum and gbbr via 10d8577 December 6, 2021 16:42
@Julio-Guerra Julio-Guerra merged commit 95c821b into v1 Dec 6, 2021
@Julio-Guerra Julio-Guerra deleted the julio.guerra/appsec-echo-integration branch December 6, 2021 17:14
programmer04 pushed a commit to programmer04/dd-trace-go that referenced this pull request Dec 7, 2021
@programmer04
contrib/labstack/echo.v4: add appsec integration (DataDog#1042)
f933e83 
Enable AppSec in echo.v4 by including the AppSec HTTP instrumentation in
the echo middleware function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

@gbbr gbbr gbbr left review comments

Assignees
No one assigned
Labels
appsec
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Julio-Guerra @knusbaum @gbbr