Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: add support for DD_SERVICE_MAPPING #1077

Merged
merged 3 commits into from
Dec 9, 2021
Merged

ddtrace/tracer: add support for DD_SERVICE_MAPPING #1077

merged 3 commits into from
Dec 9, 2021

Conversation

mackjmr
Copy link
Member

@mackjmr mackjmr commented Dec 3, 2021

This PR add's support for service mapping through:

  • Env var DD_SERVICE_MAPPING
  • StartOption WithServiceMapping

Fixes: #1058

@mackjmr mackjmr requested a review from gbbr December 3, 2021 10:46
gbbr
gbbr reviewed Dec 3, 2021
View reviewed changes
ddtrace/tracer/log.go Outdated Show resolved Hide resolved
ddtrace/tracer/option.go Outdated Show resolved Hide resolved
ddtrace/tracer/option.go Outdated Show resolved Hide resolved
ddtrace/tracer/tracer_test.go Outdated Show resolved Hide resolved
gbbr
gbbr reviewed Dec 6, 2021
View reviewed changes
ddtrace/tracer/log.go Outdated Show resolved Hide resolved
gbbr
gbbr approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👌🏻

@gbbr gbbr added this to the 1.35.0 milestone Dec 9, 2021
@gbbr gbbr merged commit 2ac0714 into v1 Dec 9, 2021
@gbbr gbbr deleted the mackjmr/DD_SERVICE_MAPPING branch December 9, 2021 10:21
mackjmr added a commit to DataDog/documentation that referenced this pull request Jan 28, 2022
@mackjmr
Document env var DD_SERVICE_MAPPING
478ed09 
Support for env var DD_SERVICE_MAPPING was added in this PR: DataDog/dd-trace-go#1077
@mackjmr mackjmr mentioned this pull request Jan 28, 2022
Merged
4 tasks
apigirl pushed a commit to DataDog/documentation that referenced this pull request Jan 28, 2022
@mackjmr @arbll
Document env var DD_SERVICE_MAPPING (#12944)
fcdf3f3 
* Document env var DD_SERVICE_MAPPING

Support for env var DD_SERVICE_MAPPING was added in this PR: DataDog/dd-trace-go#1077

* Update wording

Change via to through

* Update content/en/tracing/setup_overview/setup/go.md

Co-authored-by: Arthur Bellal <arthur.bellal@datadoghq.com>

* Apply suggestions from code review

Co-authored-by: Arthur Bellal <arthur.bellal@datadoghq.com>
Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com>
@matlegit matlegit mentioned this pull request Feb 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbr gbbr gbbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.

proposal: support for DD_SERVICE_MAPPING environment key
2 participants
@mackjmr @gbbr