contrib/internal/httputil: return correct wrapped response writer #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
changed the title
knusbaum
previously requested changes
Dec 4, 2021
Julio-Guerra
requested changes
Dec 6, 2021
There was a problem hiding this comment.
Thanks for contributing :-)
I just added the test that was missing and would have caught the issue you fix here.
The patch you propose is actually incorrect: trace_gen.go is a generated file and you should instead fix make_responsewriter.go and then run go run ./make_responsewriter.go > trace_gen.go to fix trace_gen.go.
Thank you :-)
Julio-Guerra
reviewed
Dec 6, 2021
gbbr
previously requested changes
Dec 6, 2021
|
Updated the file that generates the code, tested and it seems to be working fine! |
Julio-Guerra
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should return the wrapped response writer and NOT the original one.
In response to this issue.