contrib/go-redis/redis.v8: add WithSkipRawCommand option and fix resource #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 14, 2021
|
LGTM |
sjmtan
previously approved these changes
Dec 14, 2021
…urce This change adds a new option called `WithSkippedRawCommand` which determines the instrumentation code to skip adding the `redis.raw_command` tag to spans. This is useful in cases when the Datadog Agent Redis obfuscation is disabled (which it is, by default) and commands may contain sensitive information. Additionally, duplicate entries and an incosistency was found when setting the resource name for Redis spans, which was fixed as part of this PR. Closes #1022
gbbr
force-pushed
the
gbbr/redis-skip-raw
branch
from
c4f5fa6
to
364d469
Compare
|
@shannontan-bolt it does matter. I want to make sure this is what you wanted and what we discussed. |
Ah - it is! I just mean that I don't think my approval is one that unblocks merge haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new option called
WithSkippedRawCommandwhichdetermines the instrumentation code to skip adding the
redis.raw_commandtag to spans. This is useful in cases when theDatadog Agent Redis obfuscation is disabled (which it is, by default)
and commands may contain sensitive information.
Additionally, duplicate entries and an incosistency was found when
setting the resource name for Redis spans, which was fixed as part of
this PR.
Closes #1022