Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition while accessing DebugLoggingEnabled attribute #110

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Fix race condition while accessing DebugLoggingEnabled attribute #110

merged 2 commits into from
Sep 7, 2017

Conversation

gabsn
Copy link

@gabsn gabsn commented Sep 5, 2017 •
edited
Loading

  • On staging since 06/09

Note: it's a breaking change in the core API, but there is no other solution here to prevent this race condition from happening.

@gabsn gabsn requested a review from palazzem September 5, 2017 22:16
@palazzem palazzem modified the milestone: 0.6.0 Sep 6, 2017
palazzem
palazzem approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me! it will be part of our next 0.6.0 release, since we're changing a lot of things to improve compatibility here.

@gabsn gabsn merged commit 8227589 into master Sep 7, 2017
gabsn pushed a commit that referenced this pull request Sep 19, 2017
Fix race condition while accessing DebugLoggingEnabled attribute (#110)
df91c24 
* Fix race condition

* Fix unit tests
@palazzem palazzem modified the milestones: 0.6.0, 0.5.1 Sep 22, 2017
@palazzem palazzem added the core label Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabsn @palazzem