contrib/gin-gonic/gin: fix incomplete examples #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracer.Start() call is not currently included in the example resulting in the process never able to flush traces to the target agent. The added lines are currently visible in the Datadog integration documentation located here https://app.datadoghq.com/apm/docs?architecture=container-based&collection=Manually%2C%20from%20a%20YAML%20file&environment=kubernetes&framework=gin&language=go
|
Hi @Hellzy, what steps do I need to take to have a milestone assigned to this PR? I reviewed the contribution guidelines and noted the request for an issue to be created but in this case, the change does not affect the library so I felt the extra issue would be unnecessary. |
gbbr
approved these changes
Mar 15, 2022
|
@gbbr I appreciate the milestone tag and merge up. I reviewed these test failures and I don't believe they are related to my change. Are there any actions I can take to continue to shepherd this to merge? Thank you for the help. |
|
All good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tracer.Start() call is not currently included in the example resulting in the process never able to flush traces to the target agent. The added lines are currently visible in the Datadog integration documentation located here.
This change adds those missing lines to save future users a potential headache.