profiler: add CPUProfileRate option #1243
Merged
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user wants to use a CPU profiling rate other than the default, they would need to be able to set the rate before each round of profiling to avoid having their rate overridden by runtime/pprof.StartCPUProfile after the first round. This is currently not possible, so add an option that we can use internally to set the rate each time. Using this option will cause a spurious warning every time profiling starts. The warning is annoying, but setting the rate will work as intended. Fixes #1242
luhenry
approved these changes
Apr 13, 2022
|
This is great, thanks @nsrip-dd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user wants to use a CPU profiling rate other than the default, they
would need to be able to set the rate before each round of profiling to
avoid having their rate overridden by runtime/pprof.StartCPUProfile
after the first round. This is currently not possible, so add an option
that we can use internally to set the rate each time.
Using this option will cause a spurious warning every time profiling
starts. The warning is annoying, but setting the rate will work as
intended.
Fixes #1242