contrib/net/http: copy request in RoundTrip #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgajg1134
previously approved these changes
Apr 22, 2022
knusbaum
previously approved these changes
May 3, 2022
|
It would be nice to be able to use We're in the process of updating our supported Go versions which will push 1.12 out of "supported" status. |
…Dog/dd-trace-go into mackjmr/roundtrip-duplicate-request
gbbr
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copy's the Request in the
RoundTrip()function to comply with the RoundTripper spec (link):With this change, a shallow copy of the request is made (
r.WithContext(ctx)returns a shallow copy of r), and then a deep copy of the Header map is made before callingtracer.Inject().Fixes: #1090