appsec: fix compilation errors due to CGO and libddwaf stripping #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stripping done by the automated script left us with an invalid binary for darwin. Use the MacOS strip binary for now.
felixge
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Just tested this locally and it fixes my compilation issue on macOS 12.3.1:
on v1 branch:
$ go test ./ddtrace/tracer/
# gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer.test
/usr/local/Cellar/go/1.18/libexec/pkg/tool/darwin_amd64/link: running clang failed: exit status 1
ld: in /Users/felix.geisendoerfer/go/src/github.com/DataDog/dd-trace-go/internal/appsec/waf/lib/darwin-amd64/libddwaf.a(PowerWAFInterface.cpp.o), section __TEXT/__eh_frame address out of range for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
FAIL gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer [build failed]
FAIL
on this branch:
go test ./ddtrace/tracer/
ok gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer 19.706s
Awesome! Thanks for checking. @felixge would you be able to merge this? |
Hellzy
added a commit
that referenced
this pull request
Apr 28, 2022
* internal/appsec/waf: fix compilation issue when CGO disabled * internal/appsec/waf: rework libddwaf stripping for darwin The stripping done by the automated script left us with an invalid binary for darwin. Use the MacOS strip binary for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waf.Context.TotalRuntime(). Changed the prototype.stripbinary for now.Also fixes: https://github.com/DataDog/appsec-go-test-app/actions/runs/2233105581