profiler: get the correct profile for goroutine wait profile #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #842 refactored the profiling code and in the proccess changed the pprof lookup for the goroutine wait profile from pprof.Lookup("goroutine") to pprof.Lookup("goroutinewait") (by looking up using the profileType.Name field as the key). That profile type doesn't exist, so the lookup always fails. The existing TestRunProfile didn't catch this because the test replaces the real profile lookup with a function that provides a fixed profile. Add an additional test that runs the real profiles and checks that they all at least show up in the uploaded batch of profiles.
felixge
approved these changes
Apr 28, 2022
| @@ -334,3 +339,72 @@ func unstartedProfiler(opts ...Option) (*profiler, error) { | |||
| p.uploadFunc = func(_ batch) error { return nil } | |||
| return p, nil | |||
| } | |||
|
|
|||
| func TestAllUploaded(t *testing.T) { | |||
There was a problem hiding this comment.
I like smoke tests like this 👍. Much nicer than the other tests that rely on hacking up internals to intercept calls and stuff.
Hellzy
pushed a commit
that referenced
this pull request
Apr 28, 2022
PR #842 refactored the profiling code and in the proccess changed the pprof lookup for the goroutine wait profile from pprof.Lookup("goroutine") to pprof.Lookup("goroutinewait") (by looking up using the profileType.Name field as the key). That profile type doesn't exist, so the lookup always fails. The existing TestRunProfile didn't catch this because the test replaces the real profile lookup with a function that provides a fixed profile. Add an additional test that runs the real profiles and checks that they all at least show up in the uploaded batch of profiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #842 refactored the profiling code and in the proccess changed the
pprof lookup for the goroutine wait profile from
to
(by looking up using the profileType.Name field as the key). That
profile type doesn't exist, so the lookup always fails.
The existing TestRunProfile didn't catch this because the test replaces
the real profile lookup with a function that provides a fixed profile.
Add an additional test that runs the real profiles and checks that they
all at least show up in the uploaded batch of profiles.