contrib/segmentio/kafka-go: add tracing of FetchMessage() calls #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is the same as the existing ReadMessage tracing: finish spans on the next call or on Close(). I'm not particularly happy with that but I also couldn't come up with a better solution without breaking the current API.
ajgajg1134
requested changes
May 18, 2022
ajgajg1134
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic is the same as the existing
ReadMessage()tracing: finish spans on the next call or onClose().I'm not particularly happy with that but I also couldn't come up with a better solution without breaking the current API.