contrib/net/http: fix flaky TestRoundTripperNetworkError #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was intended to cause an HTTP request to time out on the client side, but this timeout was induced with a short sleep in the HTTP handler. This caused the test to sometimes fail in CI. Removing the sleep made the test fail consistently. To force the client to time out, make the handler wait on a channel that doesn't close until the end of the test. This fix can be verified locally by setting the client timeout to a very long value like 1 minute. The test will still pass. Fixes #1291.
ajgajg1134
approved these changes
May 13, 2022
|
Awesome. Thanks @nsrip-dd and @ajgajg1134 for review 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was intended to cause an HTTP request to time out on the client
side, but this timeout was induced with a short sleep in the HTTP
handler. This caused the test to sometimes fail in CI. Removing the
sleep made the test fail consistently.
To force the client to time out, make the handler wait on a channel that
doesn't close until the end of the test.
This fix can be verified locally by setting the client timeout to a very
long value like 1 minute. The test will still pass.
Fixes #1291.