adding WithCustomTag to a few libs in contrib/: gorm/gorm.v1, confluentinc/confluent-kafka-go/kafka, database/sql, google.golang.org/grpc

[duxing]

support custom tags for a few libs in contrib/:

• gorm.io/gorm.v1
• confluentinc/confluent-kafka-go/kafka
• database/sql
• google.golang.org/grpc

Fixes #1308

[ajgajg1134]

Hi duxing! Thanks for this contribution, it looks like a good idea to bring both these versions to feature parity. Just one small comment I've attached, and also can you add a unit test for this change? You may be able to borrow nearly all the test from the previous version which has a test TestCustomTags that covers this.

Thanks again!

[duxing]

hi @ajgajg1134 sorry about the delay. I was able to get to this last night and added test coverage for everything I introduced. can you take another look when you have a chance?

I noticed the CI fails complaining about DD_API_KEY missing in the env (and another bitnami/kafka related issue). I'm not sure how to address these ones, it'll be helpful if you can share some insights with me

[duxing]

hi @ajgajg1134 can you help me understand why my PR fails due to:

Neither DATADOG_API_KEY nor DD_API_KEY is in your environment.
Internal Error: API key is missing
when other PRs (eg. this and this ) don't have the problem? it's probably something trivial and I'd like to figure out what I missed.

thanks in advance!

[ajgajg1134]

hi @ajgajg1134 can you help me understand why my PR fails due to:

Neither DATADOG_API_KEY nor DD_API_KEY is in your environment.
Internal Error: API key is missing
when other PRs (eg. this and this ) don't have the problem? it's probably something trivial and I'd like to figure out what I missed.

thanks in advance!

Hello @duxing! Sorry, the system-test failures you're seeing are due to this PR running a branch from an external fork of the repository. Unfortunately it means these tests can't be run unless the branch is coming from within the repository, although we can run the other tests still and should be able to merge after review is complete. (This is a limitation of github actions that hopefully is resolved at some point)

[duxing]

@ajgajg1134 thx for explaining, i figured it has something to do with the github action settings. I've disabled my own fork since it's complaining about the same thing.

is it possible to cherry-pick my change to a branch for this repo and proceed?

[ajgajg1134]

Closing this PR since the work was merged with #1359
Thanks for the contribution!