Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/database/sql: Add WithErrorCheck options #1315

Merged
merged 14 commits into from
Aug 29, 2022
Merged

contrib/database/sql: Add WithErrorCheck options #1315

merged 14 commits into from
Aug 29, 2022

Commits on Jun 2, 2022

  1. contrib/database/sql: Add WithErrorCheck options 

    WithErrorCheck specifies a function fn which determines whether the passed
error should be marked as an error. The fn is called whenever a database/sql operation
finishes with an error.

close DataDog#1314
    @soh335
    soh335 committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    be59f6b View commit details
    Browse the repository at this point in the history

  2. Update contrib/database/sql/conn.go 

    Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
    @soh335 @gbbr
    soh335 and gbbr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    0b5aac0 View commit details
    Browse the repository at this point in the history

  3. Update contrib/database/sql/conn_test.go 

    Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
    @soh335 @gbbr
    soh335 and gbbr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    bee3a84 View commit details
    Browse the repository at this point in the history

  4. refacotirng TestWithErrorCheck

    @soh335
    soh335 committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    57026f7 View commit details
    Browse the repository at this point in the history

  5. remove unsed code

    @soh335
    soh335 committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f5f92bd View commit details
    Browse the repository at this point in the history

  6. Update contrib/database/sql/conn.go 

    Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
    @soh335 @gbbr
    soh335 and gbbr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    f0a3c15 View commit details
    Browse the repository at this point in the history

  7. just fallback to rc.errCheck

    @soh335
    soh335 committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    2f80147 View commit details
    Browse the repository at this point in the history

  8. Update contrib/database/sql/conn.go 

    Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
    @soh335 @gbbr
    soh335 and gbbr committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    4f554ea View commit details
    Browse the repository at this point in the history

  9. fix mark as error condition

    @soh335
    soh335 committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    05169fc View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Merge branch 'main' into v1-contrib-db-sql-error-with-check

    @katiehockman
    katiehockman committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    8c84c94 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. fix indent

    @soh335
    soh335 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4d938fe View commit details
    Browse the repository at this point in the history

  2. fix indent

    @soh335
    soh335 committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    c3a4ac8 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Merge branch 'main' into v1-contrib-db-sql-error-with-check

    @soh335
    soh335 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0b8f017 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Merge branch 'main' into v1-contrib-db-sql-error-with-check

    @gbbr
    gbbr committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b29cbdc View commit details
    Browse the repository at this point in the history