-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/gocql/gocql: add WithErrorCheck #1316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericjster
reviewed
Jun 1, 2022
gbbr
reviewed
Jun 2, 2022
gbbr
suggested changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good, but we need to apply the change differently.
gbbr
reviewed
Jun 30, 2022
gbbr
reviewed
Jun 30, 2022
gbbr
suggested changes
Jun 30, 2022
gbbr
previously approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Christian 🙏🏻
866debf
to
c41796b
Compare
gbbr
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cassandra services report a super high level of errors, when it's only queries returning no data because the selectors do not match. As show in the example, if you just
SELECT ...
something that is not in the DB -> returns as an error.This only happens when using
Scan
though, using an iterator, the "problem" does not surface.The patch uses ideas from #1314 and #1315 or #940 (already merged) and introduces a
WithErrorCheck
option with allows callers to consider that some errors should not be reported by APM.A typical override would look like: