go.mod: bump several dependency versions to avoid vulnerabilities #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.mongodb.org/mongo-driver -> v1.7.5 golang/github.com/jinzhu/gorm -> v1.9.10 Fixes #1335
nsrip-dd
reviewed
Jun 15, 2022
There was a problem hiding this comment.
Thanks Kyle! If you think it would be appropriate, I can open a PR to change the jiznhu/gorm tests so they don't break because of slight changes in the SQL query text formatting (like this failure). Other than those failures I suspect this upgrade doesn't actually break that integration.
|
Thanks, @nsrip-dd. I have time to go ahead and fix those tests. I agree, the upgrade doesn't break the integration. We just happen to depend on specific behavior from that specific version for the tests. Not ideal, but it's fine for now. |
nsrip-dd
previously approved these changes
Jun 15, 2022
The spans should be tagged with the query, but the exact format of the query can change between gorm library versions (e.g. inserting extra whitespace). We can get the text through a callback and compare against that rather than hard-coding the text.
katiehockman
approved these changes
Jun 22, 2022
| @@ -42,8 +41,7 @@ require ( | |||
| github.com/gomodule/redigo v1.7.0 | |||
| github.com/google/pprof v0.0.0-20210423192551-a2663126120b | |||
| github.com/google/uuid v1.3.0 | |||
| github.com/gorilla/context v1.1.1 // indirect | |||
There was a problem hiding this comment.
Were these other go.mod changes just from go mod tidy?
nsrip-dd
approved these changes
Jul 6, 2022
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.mongodb.org/mongo-driver -> v1.7.5
golang/github.com/jinzhu/gorm -> v1.9.10
Fixes #1335