Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetTag convert value to string instead of expected a string #135

Merged
merged 1 commit into from
Dec 26, 2017
Merged

SetTag convert value to string instead of expected a string #135

merged 1 commit into from
Dec 26, 2017

Conversation

chibimi
Copy link
Contributor

@chibimi chibimi commented Dec 21, 2017

The SetTag function accept an interface{} for the value parameter but it panic when the value is not a string.

@palazzem palazzem added the core label Dec 26, 2017
@palazzem palazzem added this to the 0.6.1 milestone Dec 26, 2017
@palazzem palazzem self-requested a review December 26, 2017 13:41
palazzem
palazzem approved these changes Dec 26, 2017
View reviewed changes
Copy link
Contributor

@palazzem palazzem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for spotting this issue in our OpenTracing compatibility layer! Good to me the change and the test! Merging it immediately!

@palazzem palazzem merged commit c9bf69d into DataDog:master Dec 26, 2017
jdgordon pushed a commit to jdgordon/dd-trace-go that referenced this pull request May 31, 2022
@hush-hush
Merge pull request DataDog#135 from DataDog/maxime/cherry-pick-deadlock
b72fddb 
Fix potential deadlock on Close()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palazzem palazzem palazzem approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chibimi @palazzem