contrib: http url in span tags #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellzy
force-pushed
the
francois.mazeau/backend-waf-http-url
branch
8 times, most recently
from
3066fb0
to
dce5511
Compare
gbbr
changed the title
Hellzy
force-pushed
the
francois.mazeau/backend-waf-http-url
branch
8 times, most recently
from
0d63f6f
to
6b77c52
Compare
Hellzy
force-pushed
the
francois.mazeau/backend-waf-http-url
branch
from
6b77c52
to
2dff1e9
Compare
gbbr
reviewed
Jun 24, 2022
ajgajg1134
reviewed
Jun 24, 2022
Hellzy
force-pushed
the
francois.mazeau/backend-waf-http-url
branch
from
0b3a892
to
2dff1e9
Compare
Hellzy
force-pushed
the
francois.mazeau/backend-waf-http-url
branch
from
92a1a80
to
37a8418
Compare
ghost
reviewed
Jun 24, 2022
gbbr
suggested changes
Jun 27, 2022
Hellzy
force-pushed
the
francois.mazeau/backend-waf-http-url
branch
from
196d789
to
f8e755a
Compare
gbbr
reviewed
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1345
With this change http.url now holds the full request URL instead of the path alone.
This also adds config.go since the configuration for httptrace became bigger and a config struct helps with convenience and initialisation.
The url is built according to https://datadoghq.atlassian.net/wiki/spaces/APM/pages/2357395856/Span+attributes#http.url