all: support latest go version 1.19 #1410
Merged
+149
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiehockman
reviewed
Aug 3, 2022
| @@ -40,9 +40,10 @@ Datadog APM for Go is built upon dependencies defined in specific versions of th | |||
| <!-- NOTE: When updating the below section ensure you update the minimum supported version listed in the public docs here: https://docs.datadoghq.com/tracing/setup_overview/setup/go/?tab=containers#compatibility-requirements --> | |||
There was a problem hiding this comment.
Is this in a separate PR?
There was a problem hiding this comment.
Ah it will / should be, thanks for the reminder since I totally forgot
There was a problem hiding this comment.
katiehockman
previously approved these changes
Aug 3, 2022
katiehockman
previously approved these changes
Aug 3, 2022
Hellzy
reviewed
Aug 4, 2022
Hellzy
previously approved these changes
Aug 8, 2022
Hellzy
approved these changes
Aug 9, 2022
gbbr
approved these changes
Aug 11, 2022
nsrip-dd
added a commit
that referenced
this pull request
Aug 30, 2022
Now that we've bumped our minimum supported Go version to 1.17 (see #1410) we can use testing.T.Setenv. This function is a test helper which sets an environment variable, and restores it to its previous value when the test ends (including un-setting the variable if it was un-set). There are a few reimplementations of this in the tests which can now be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves 1.17 to maintenance and 1.16 to legacy support