Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/telemetry: give user config priority over environment #1429

Merged
merged 2 commits into from
Aug 16, 2022
Merged

internal/telemetry: give user config priority over environment #1429

merged 2 commits into from
Aug 16, 2022

Conversation

nsrip-dd
Copy link
Contributor

This matches how we do it everywhere else

@nsrip-dd
internal/telemetry: give user config priority over environment
ed73f30 
This matches how we do it everywhere else
@nsrip-dd nsrip-dd requested a review from a team as a code owner August 15, 2022 18:09
@nsrip-dd nsrip-dd added this to the Triage milestone Aug 15, 2022
pmbauer
pmbauer approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@pmbauer pmbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nsrip-dd nsrip-dd merged commit a70f874 into main Aug 16, 2022
@nsrip-dd nsrip-dd deleted the nick.ripley/telemetry-env-var-priority branch August 16, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbauer pmbauer pmbauer approved these changes

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Triage
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nsrip-dd @pmbauer @ajgajg1134