Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiler: wrap delta profiling in a type #1483

Merged
merged 4 commits into from
Sep 30, 2022
Merged

profiler: wrap delta profiling in a type #1483

merged 4 commits into from
Sep 30, 2022

Commits on Sep 30, 2022

  1. profiler: wrap delta profiling in a type 

    Wrap up delta profiling in a type with a Delta method. This type holds
any information about the previous profile needed to compute the delta
with the newest profile. The profiler keeps an instance of type for each
profile type which supports delta profiling. This better encapsulates
the implementation details of delta profiling, and facilitates upcoming
implementation changes.

As part of this change, pull the logic for merging in "extra" profiles
out of the delta profiling code path. This logic was implemented for C
allocation profiling, and the extra data was passed through to delta
profiling mainly for efficiency. However, merging in extra data is
orthogonal to delta profiling and we can find other ways to make that
more efficient if we need to.
    @nsrip-dd
    nsrip-dd committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    e32e8ee View commit details
    Browse the repository at this point in the history

  2. profiler: add constructor for deltaProfiler 

    Push more of the implementation details into the deltaProfiler type
    @nsrip-dd
    nsrip-dd committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    57374a0 View commit details
    Browse the repository at this point in the history

  3. profiler: make delta do nothing by default, respond to review comments 

    Change the Delta field of profileType to DeltaValue, a list of values
for which to compute deltas. A length-0 DeltaValue means that the
profile type doesn't support delta profiles. This gets rid of the
overloaded meaning of Delta == nil meaning "do nothing" and
len(Delta.SampleTypes) == 0 mean "do everything".
    @nsrip-dd
    nsrip-dd committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    a5ee2e5 View commit details
    Browse the repository at this point in the history

  4. profiler: make deltas keys ProfileType instead of string

    @nsrip-dd
    nsrip-dd committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    d796776 View commit details
    Browse the repository at this point in the history