contrib/99designs/gqlgen: avoid adding the example dependencies into our go.mod #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
previously approved these changes
Oct 6, 2022
….mod The gqlgen example was leading to github.com/BurntSushi/toml being upgraded to v1 and forcing our dd-trace-go users to do so, leading to breaking changes. Such code examples shouldn't introduce breaking changes to dd-trace-go's go.mod file.So the example was moved into the package godoc to avoid adding its dependencies into dd-trace-go's go.mod file
Julio-Guerra
force-pushed
the
julio.guerra/downgrade-gqlgen
branch
from
b9eb1ec
to
33214ea
Compare
Julio-Guerra
changed the title
|
This got merged into release-v1.43.x already to avoid the issue |
ajgajg1134
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gqlgen example was leading to github.com/BurntSushi/toml being upgraded
to v1 and forcing our dd-trace-go users to do so, leading to breaking changes.
Such code examples shouldn't introduce breaking changes to dd-trace-go's go.mod
file.So the example was moved into the package godoc to avoid adding its dependencies
into dd-trace-go's go.mod file