opentracing: set Span error when adding error tags #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
suggested changes
Jan 18, 2018
opentracing/span.go
Outdated
| @@ -64,6 +65,9 @@ func (s *Span) SetTag(key string, value interface{}) ot.Span { | |||
| s.Span.Lock() | |||
| defer s.Span.Unlock() | |||
| s.Span.Type = fmt.Sprint(value) | |||
| case ErrorMsg, ErrorType, ErrorStack: | |||
There was a problem hiding this comment.
as we've discussed you can pass the actual Error so SetError will be used
gbbr
force-pushed
the
gbbr/opentracing-error
branch
2 times, most recently
from
f2e3cdf
to
88408d7
Compare
This change allows setting a tag of name Error ("error") having a value
of error (but covers for other types to) which will in turn set the
error properties of the Span internally.
Fixes #144
gbbr
force-pushed
the
gbbr/opentracing-error
branch
from
88408d7
to
53d66e2
Compare
palazzem
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows setting a tag of name Error ("error") having a value
of error (but covers for other types to) which will in turn set the
error properties of the Span internally.
Fixes #144