opentracing: allow customizing propagator headers #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/propagator-headers
branch
2 times, most recently
from
51de369
to
e9e6857
Compare
gbbr
force-pushed
the
gbbr/propagator-headers
branch
3 times, most recently
from
728f61d
to
73ac71d
Compare
gbbr
force-pushed
the
gbbr/propagator-headers
branch
from
73ac71d
to
ebf4470
Compare
palazzem
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the possibility of customizing the
opentracing.TextMappropagator that is used in the tracer. A default implementation is provided which exposes a constructor that allows configuring the headers used when attaching values into the map.Feature
If users would want to override the default TextMap propagator, an example configuration could be:
This will prefix all baggage header keys with "ot-baggage-" and will define trace and parent map keys as "x-trace-id" and "x-parent-id".