Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/database/sql: Rename SQLCommentInjection to DBMPropagation #1556

Conversation

alexandre-normand
Copy link
Contributor

@alexandre-normand alexandre-normand commented Oct 31, 2022

The go tracer was the first one to implement the dbm trace context propagation which we referred to as sql comment injection then. As we've had more discussions after work started with other tracers, we started gravitating towards the dbm propagation naming instead.

This PR aligns the go tracer with the naming used by the second wave of tracers implementing the feature. Nothing changes as far as functionality is concerned and this change is made to be backward compatible to avoid breaking any existing usages of the old names.

Additionally, a few documentation updates are included here to help usage:

  • We have a data privacy text that we want to make sure is included in documentation surrounding the feature and that privacy text is now included in relevant portions of the godoc.
  • Added: a dbm propagation example in the contrib/database/sql package.

@alexandre-normand alexandre-normand added this to the v1.44.0 milestone Oct 31, 2022
@alexandre-normand alexandre-normand marked this pull request as ready for review November 1, 2022 16:49
@alexandre-normand alexandre-normand requested a review from a team November 1, 2022 16:49
@alexandre-normand
Copy link
Contributor Author

Thanks for the review, @dianashevchenko ! Feel free to merge when it's appropriate (since I don't have permissions to do this myself).

@dianashevchenko dianashevchenko merged commit 61c5926 into main Nov 3, 2022
@dianashevchenko dianashevchenko deleted the alex.normand/rename-sql-comment-injection-to-dbm-propagation branch November 3, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants