profiler: add the Name field back for the CPU profile #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally removed by #1485
|
This doesn't seem to have been load bearing... The Name field is used to implement the String method for ProfileType, and that's only used in the startup log (explicitly) and when generating the profile type tag (implicitly, through a "%s" formatting string), which is in turn only used for some metrics. There was a test for the startup log output that was supposed to catch this, but didn't, so I updated the test to be a little more specific about the expected output. |
BenchmarksFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally removed by #1485