fix duration in (fast)delta profiles #1612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a bug in the duration computation for fast delta
The current version produces delta pprofs with a
DurationNanos
~equal to the life of the process.Note: this was a regression from a previously tested version of fastdelta. Unfortunately, there wasn't sufficient test coverage for this case. This pull addresses that too.
Describe how to test/QA your changes
follow test procedure executed for fast delta
Reviewer's Checklist
Triage
milestone is set.