Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: change agent remote-config package enforcing our working fork #1613

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

Julio-Guerra
Copy link
Contributor

What does this PR do?

This patch release fixes #1607 with Go modules version selection when dd-trace-go is updated using go get -u all, where an unstable indirect dependency was unexpectedly upgrading to an incompatible version and therefore leading to a compilation error.

Motivation

Avoid go get -u all issue.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@Julio-Guerra Julio-Guerra added this to the v1.45.0 milestone Dec 8, 2022
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner December 8, 2022 10:19
@pr-commenter
Copy link

pr-commenter bot commented Dec 8, 2022

Benchmarks

Comparing candidate commit 5a0236b in PR branch julio.guerra/backport-go-tuf-fix with baseline commit 5639eb2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Julio-Guerra Julio-Guerra merged commit ce33558 into main Dec 8, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/backport-go-tuf-fix branch December 8, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] v1.44.0 seems to pull in a broken pkg
2 participants