Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase multi-OS test timeout from 10 minutes to 15 minutes #1637

Merged
merged 3 commits into from
Dec 30, 2022

Conversation

nsrip-dd
Copy link
Contributor

@nsrip-dd nsrip-dd commented Dec 28, 2022

What does this PR do?

Increase the timeout for multi-OS unit tests to 15 minutes.

Motivation

The ddtrace/tracer tests take longer than 10 minutes to run on the
GitHub Windows runners. Since 10 minutes is the default Go test timeout,
that means the tests are now failing to complete. Increase the timeout
to 15 minutes to give more headroom until we can figure out why the
tests are taking so long.

Describe how to test/QA your changes

Run the unit tests on Windows with this increased timeout, see if they pass.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

The ddtrace/tracer tests take longer than 10 minutes to run on the
GitHub Windows runners. Since 10 minutes is the default Go test timeout,
that means the tests are now failing to complete. Increase the timeout
to 15 minutes to give more headroom until we can figure out why the
tests are taking so long.
@nsrip-dd nsrip-dd requested a review from a team as a code owner December 28, 2022 16:35
@nsrip-dd nsrip-dd added this to the v1.46.0 milestone Dec 28, 2022
@pr-commenter
Copy link

pr-commenter bot commented Dec 28, 2022

Benchmarks

Comparing candidate commit 874b8b4 in PR branch nick.ripley/bump-windows-ci-timeout with baseline commit a76b1cb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@nsrip-dd
Copy link
Contributor Author

nsrip-dd commented Dec 28, 2022

I've manually dispatched the multi-OS tests on Windows to see if they pass with the increased timeout: https://github.com/DataDog/dd-trace-go/actions/runs/3795352800/jobs/6454387438

We can hold off on merging this until we get a run to pass, in case I need to bump the timeout more.

@nsrip-dd
Copy link
Contributor Author

The Windows tests succeeded on this branch. ddtrace/tracer took 10 minutes and 30 seconds, so just over the default 10 minute timeout. 15 minutes should be enough for now.

@nsrip-dd nsrip-dd merged commit 0405d1f into main Dec 30, 2022
@nsrip-dd nsrip-dd deleted the nick.ripley/bump-windows-ci-timeout branch December 30, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants