Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitlab/scripts: add more benchmarks to benchmarking platform #1672

Merged
merged 7 commits into from
Mar 14, 2023
Merged

.gitlab/scripts: add more benchmarks to benchmarking platform #1672

merged 7 commits into from
Mar 14, 2023

Conversation

lievan
Copy link
Contributor

@lievan lievan commented Jan 17, 2023 •
edited
Loading

What does this PR do?

Adds BenchmarkSingleSpanRetention, BenchmarkInjectW3C to the benchmarking platform.

Motivation

Increase benchmark coverage for the tracer

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@lievan lievan added this to the v1.47.0 milestone Jan 17, 2023
@lievan lievan requested a review from a team as a code owner January 17, 2023 22:07
@pr-commenter
Copy link

pr-commenter bot commented Jan 17, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit 8d3855e in PR branch evan.li/add-SingleSpanRetention-Benchmark with baseline commit a56634f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@knusbaum knusbaum modified the milestones: v1.47.0, v1.48.0 Feb 1, 2023
@Hellzy Hellzy modified the milestones: v1.48.0, v1.49.0 Feb 27, 2023
@lievan lievan changed the title .gitlab/scripts: add SingleSpanRetention benchmark to benchmarking platform .gitlab/scripts: add more benchmarks to benchmarking platform Mar 14, 2023
@lievan lievan requested a review from a team March 14, 2023 15:54
knusbaum
knusbaum approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@knusbaum knusbaum merged commit 1f7d47a into main Mar 14, 2023
@knusbaum knusbaum deleted the evan.li/add-SingleSpanRetention-Benchmark branch March 14, 2023 17:30
ddyurchenko pushed a commit that referenced this pull request Mar 17, 2023
@lievan @ddyurchenko
.gitlab/scripts: add more benchmarks to benchmarking platform (#1672)
2de4fcb 
Adds BenchmarkSingleSpanRetention, BenchmarkInjectW3C to the benchmarking
platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knusbaum knusbaum knusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.49.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lievan @knusbaum @Hellzy