Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: fixed propagator not updating the tracestate header a… #1676

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Fixes a bug where propagator doesn't update the tracestate header after changing sampling decision on the span.
Also cleans up the tests in regards to that.

Motivation

Describe how to test/QA your changes

  • Extract context (pCtx) from header ( verify it's as expected )
  • Create a span with ChildOf(pctx) option
  • Change priority on the span to a different value.
  • Inject span context into an empty headers map and verify that the tracestate is updated

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@dianashevchenko dianashevchenko requested a review from a team January 19, 2023 14:39
@dianashevchenko dianashevchenko added this to the v1.47.0 milestone Jan 19, 2023
@pr-commenter
Copy link

pr-commenter bot commented Jan 19, 2023

Benchmarks

Comparing candidate commit 152c599 in PR branch shevchenko/w3c-updated with baseline commit e1d94a7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@dianashevchenko dianashevchenko merged commit 2dd2f38 into main Jan 19, 2023
@dianashevchenko dianashevchenko deleted the shevchenko/w3c-updated branch January 19, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants