tracer: remove WithTraceID128 #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgajg1134
approved these changes
Jan 24, 2023
katiehockman
added a commit
that referenced
this pull request
Feb 16, 2023
Remove the WithTraceID128 API that was added to this feature branch (not currently in a dd-trace-go release or in main).
katiehockman
added a commit
that referenced
this pull request
Feb 16, 2023
Remove the WithTraceID128 API that was added to this feature branch (not currently in a dd-trace-go release or in main).
katiehockman
added a commit
that referenced
this pull request
Mar 7, 2023
Remove the WithTraceID128 API that was added to this feature branch (not currently in a dd-trace-go release or in main).
katiehockman
added a commit
that referenced
this pull request
Mar 7, 2023
Remove the WithTraceID128 API that was added to this feature branch (not currently in a dd-trace-go release or in main).
katiehockman
added a commit
that referenced
this pull request
Mar 27, 2023
Remove the WithTraceID128 API that was added to this feature branch (not currently in a dd-trace-go release or in main).
katiehockman
added a commit
that referenced
this pull request
Mar 28, 2023
Remove the WithTraceID128 API that was added to this feature branch (not currently in a dd-trace-go release or in main).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the
WithTraceID128API that was added to this feature branch (not currently in a dd-trace-go release or in main).Motivation
There isn't enough evidence that we need this API at this time, and the UX is confusing as it is. Currently, the only way to set the trace id programmatically is for root spans using
WithSpanID, which then applies the trace id. Adding a separate API just to set the higher bits is likely to lead to confusion, and we should redesign this for v2 anyway.Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.