contrib/net/http: errCheck function #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneswuerbach
force-pushed
the
roundtripper-errcheck
branch
from
b35ba2e
to
edc342d
Compare
|
@knusbaum sorry for the direct ping, but any chance to get this or something similar merge? This is currently polluting our error tracking :-/ |
katiehockman
previously approved these changes
Feb 14, 2023
johanneswuerbach
force-pushed
the
roundtripper-errcheck
branch
from
edc342d
to
7833918
Compare
katiehockman
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an
errCheckfunction to the net/http roundtripper to decide whether a span should be treated as errored or not.Motivation
This applies the same logic introduced by #1315 on sql tracer. We need this otherwise DD raises an issue for every kind of error.
Describe how to test/QA your changes
Additional unit test.
Reviewer's Checklist
Triagemilestone is set.