Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracer: support 128-bit propagation of B3 multi header #1717

Merged
merged 12 commits into from
Feb 8, 2023
Merged

tracer: support 128-bit propagation of B3 multi header #1717

merged 12 commits into from
Feb 8, 2023

Conversation

katiehockman
Copy link
Contributor

@katiehockman katiehockman commented Feb 3, 2023 •
edited
Loading

What does this PR do?

Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.

Updates #909

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented Feb 3, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit d187709 in PR branch katiehockman/128-propagation with baseline commit a05f3e0 in branch shared/128-bit.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 4 cases.

scenario:BenchmarkConcurrentTracing-24

  • 🟥 execution_time [+0.028ms; +0.039ms] or [+2.737%; +3.767%]

scenario:BenchmarkStartSpan-24

  • 🟩 execution_time [-0.066µs; -0.034µs] or [-2.775%; -1.427%]

@katiehockman katiehockman marked this pull request as ready for review February 3, 2023 18:05
@katiehockman katiehockman requested a review from a team February 3, 2023 18:05
@katiehockman katiehockman added this to the Triage milestone Feb 3, 2023
ajgajg1134
ajgajg1134 reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! Just one small question about a comment

ddtrace/tracer/textmap_test.go Outdated Show resolved Hide resolved
ajgajg1134
ajgajg1134 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@katiehockman katiehockman merged commit 3319756 into shared/128-bit Feb 8, 2023
@katiehockman katiehockman deleted the katiehockman/128-propagation branch February 8, 2023 17:50
katiehockman added a commit that referenced this pull request Feb 16, 2023
@katiehockman
tracer: support 128-bit propagation of B3 multi header (#1717)
b2dfa97 
Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.
katiehockman added a commit that referenced this pull request Feb 16, 2023
@katiehockman
tracer: support 128-bit propagation of B3 multi header (#1717)
2e3c7c0 
Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.
katiehockman added a commit that referenced this pull request Mar 7, 2023
@katiehockman
tracer: support 128-bit propagation of B3 multi header (#1717)
3142796 
Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.
katiehockman added a commit that referenced this pull request Mar 7, 2023
@katiehockman
tracer: support 128-bit propagation of B3 multi header (#1717)
0877cc5 
Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.
katiehockman added a commit that referenced this pull request Mar 27, 2023
@katiehockman
tracer: support 128-bit propagation of B3 multi header (#1717)
58df9d0 
Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.
katiehockman added a commit that referenced this pull request Mar 28, 2023
@katiehockman
tracer: support 128-bit propagation of B3 multi header (#1717)
2c2005b 
Supports 128-bit trace id propagation in B3 multi headers. Other carriers will be supported in future PRs, and TODOs have been added in the code where it is needed.

Also fixes the issue where a spanContext needed to have an associated span to access and store 128-bit trace ids. It is now a separate field of the spanContext. Now, the _dd.p.tid tag in the Meta map (upper 64 bits of 128-bit trace ID) is populated from the spanContext upon span finish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

@knusbaum knusbaum Awaiting requested review from knusbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Triage
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katiehockman @ajgajg1134