contrib/go-redis: add redis db index tag #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarguelloF
force-pushed
the
rarguelloF/go-redis-add-db-index-tag
branch
2 times, most recently
from
d70b2ba
to
cc9f45a
Compare
zarirhamza
previously approved these changes
Feb 22, 2023
rarguelloF
force-pushed
the
rarguelloF/go-redis-add-db-index-tag
branch
from
cc9f45a
to
f7623e6
Compare
katiehockman
reviewed
Mar 2, 2023
ajgajg1134
reviewed
Apr 4, 2023
| @@ -122,10 +122,11 @@ func (c *Pipeliner) execWithContext(ctx context.Context) ([]redis.Cmder, error) | |||
| tracer.ResourceName("redis"), | |||
| tracer.Tag(ext.TargetHost, p.host), | |||
| tracer.Tag(ext.TargetPort, p.port), | |||
| tracer.Tag("out.db", p.db), | |||
| tracer.Tag("out.db", strconv.Itoa(p.db)), | |||
There was a problem hiding this comment.
Is it possible for the type change here to break an existing customer? (I noticed the other major versions of this already use a string here, it's curious this version doesn't)
There was a problem hiding this comment.
out.db should not change in this PR (I just changed where the string conversion is happening, since the new db.redis.database_index is an int).
Please let me know if this clarifies the question or if I missed something else.
There was a problem hiding this comment.
Oh I see, I missed that the strconv was happening before, just in a different spot. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
db.redis.database_indextag to the following integrations:contrib/go-redis/rediscontrib/go-redis/redis.v7contrib/go-redis/redis.v8Motivation
Unify span tags across tracers.
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.