Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer/textmap: always extract baggage when using w3c for compatability #1759

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

With the new default of preferring w3c headers, if a user were to receive datadog baggage items they were lost as the w3c extract would successfully pull the trace id and other information but skip the baggage

Motivation

Closes #1752
The RFC states we should do this too:

If the Datadog tracing library previously propagated ot-baggage automatically via the Datadog propagator, then extract the ot-baggage header for OpenTracing baggage propagation.

Describe how to test/QA your changes

Added a unit test to cover this

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@ajgajg1134 ajgajg1134 requested a review from a team February 21, 2023 21:01
@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2023

Benchmarks

Comparing candidate commit 2697f0d in PR branch andrew.glaude/BaggageInW3c with baseline commit d343e64 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@ajgajg1134 ajgajg1134 added this to the v1.49.0 milestone Feb 21, 2023
@katiehockman katiehockman modified the milestones: v1.49.0, v1.48.0 Feb 21, 2023
@ajgajg1134 ajgajg1134 merged commit ccb1ff2 into main Feb 21, 2023
@ajgajg1134 ajgajg1134 deleted the andrew.glaude/BaggageInW3c branch February 21, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Baggage is lost by Extract
2 participants