Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/elastic/go-elasticsearch: Add support for elasticsearch v8 (Follow-up) #1763

Merged
merged 33 commits into from
Feb 24, 2023

Conversation

VJean
Copy link
Contributor

@VJean VJean commented Feb 23, 2023

This is a follow-up of PR #1363 .

This PR adds tracing support for Elasticsearch 8.

@pr-commenter
Copy link

pr-commenter bot commented Feb 23, 2023

Benchmarks

Comparing candidate commit c764307 in PR branch vjean/elasticsearch-v8-support with baseline commit 4814178 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@VJean VJean force-pushed the vjean/elasticsearch-v8-support branch from 9c13ec3 to ab1241d Compare February 23, 2023 16:09
@VJean VJean force-pushed the vjean/elasticsearch-v8-support branch from ab1241d to afa7058 Compare February 23, 2023 16:40
it's enabled by default, contrary to the previous major versions
@VJean VJean marked this pull request as ready for review February 23, 2023 17:54
@VJean VJean requested a review from a team February 23, 2023 17:54
@VJean VJean requested a review from a team as a code owner February 23, 2023 17:54
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good: Just one ask to remove some unrelated changes

contrib/99designs/gqlgen/tracer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this!

@ajgajg1134 ajgajg1134 added this to the v1.49.0 milestone Feb 24, 2023
@ajgajg1134 ajgajg1134 merged commit 5ff4c5c into main Feb 24, 2023
@ajgajg1134 ajgajg1134 deleted the vjean/elasticsearch-v8-support branch February 24, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants