Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: record timestamp at the start execution tracing #1766

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

nsrip-dd
Copy link
Contributor

What does this PR do?

Sets the timestamp for the last execution trace recording at the beginning,
rather than the end, of recording.

Motivation

Setting a tracing period matching the profile period will do the expected thing
of sending a trace with every profile upload, rather than every other profile
upload.

Describe how to test/QA your changes

The unit test has been updated. Previously, with a profile period of 1 second
and a trace period of 3 seconds, it took 5 uploads to see the expected 2
traces. But really it should only have taken 4.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

... rather than the end. This way, setting a tracing period matching the
profile period will do the expected thing of sending a trace with every
profile upload, rather than every _other_ profile upload.
@nsrip-dd nsrip-dd requested a review from a team as a code owner February 28, 2023 13:31
@nsrip-dd nsrip-dd added this to the v1.49.0 milestone Feb 28, 2023
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2023

Benchmarks

Comparing candidate commit 0bda85e in PR branch nick.ripley/fix-exec-trace-timing with baseline commit 0614a05 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🙇

@nsrip-dd nsrip-dd merged commit 01171fe into main Feb 28, 2023
@nsrip-dd nsrip-dd deleted the nick.ripley/fix-exec-trace-timing branch February 28, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants