Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracer: small refactor for SQL tracing #1777

Merged
merged 2 commits into from
Mar 6, 2023
Merged

tracer: small refactor for SQL tracing #1777

merged 2 commits into from
Mar 6, 2023

Conversation

katiehockman
Copy link
Contributor

What does this PR do?

Just a small refactor for readability that I noticed while investigating this code.

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@katiehockman katiehockman added this to the v1.49.0 milestone Mar 3, 2023
@katiehockman katiehockman marked this pull request as ready for review March 3, 2023 20:11
@katiehockman katiehockman requested a review from a team March 3, 2023 20:11
@pr-commenter
Copy link

pr-commenter bot commented Mar 3, 2023 •
edited
Loading

Benchmarks

Comparing candidate commit 4680579 in PR branch katiehockman/sql with baseline commit a494955 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

ajgajg1134
ajgajg1134 approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@katiehockman katiehockman merged commit ca9d19d into main Mar 6, 2023
@katiehockman katiehockman deleted the katiehockman/sql branch March 6, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-normand alexandre-normand alexandre-normand approved these changes

@ajgajg1134 ajgajg1134 ajgajg1134 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.49.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katiehockman @alexandre-normand @ajgajg1134