contrib/go-redis/redis.v8: fix broken parsing of redis commands #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code made some assumptions about the format of the commands that were not correct, namely that they would always contain at least 1 space. This seems to be true for commands generated by the library, but not necessarily for commands given as text to the Do function, e.g. client.Do(ctx, "PING"). This results in a panic due to out-of-bounds indexing. This commit makes the parsing code not assume this format and adds a test case to ensure it works correctly for commands with zero spaces.
katiehockman
approved these changes
Mar 6, 2023
katiehockman
pushed a commit
that referenced
this pull request
Jun 6, 2023
Co-authored-by: Diana Shevchenko <40775148+dianashevchenko@users.noreply.github.com> Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The previous code made some assumptions about the format of the commands that were not correct, namely that they would always contain at least 1 space. This seems to be true for commands generated by the library, but not necessarily for commands given as text to the Do function, e.g. client.Do(ctx, "PING").
This results in a panic due to out-of-bounds indexing.
This commit makes the parsing code not assume this format and adds a test case to ensure it works correctly for commands with zero spaces.
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.