Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: integrate APM E2E tests in Github Actions CI #1784

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

lambrospetrou
Copy link
Contributor

@lambrospetrou lambrospetrou commented Mar 7, 2023

What does this PR do?

This PR enables the APM end-to-end (E2E) tests in Github Actions CI.

At the moment, the default test is enabled for all variants, but the Single Spans test is only implemented for the chi variant. All other variants will still run the jobs, but are skipped (in system-tests terms they are expectedly failing).

Once we verify that this works well, we can implement the rest variants too, in follow-up PRs.

Examples of successful jobs:

Motivation

We had several incidents with features not working correctly due to incorrect assumptions, and bugs, in some component of the whole APM tracing pipeline (tracer, agent, backend).

We want to enable end-to-end tests for key use-cases to avoid regressions in the future.
See ATI-2419 for more details.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented Mar 7, 2023

Benchmarks

Comparing candidate commit c2b671b in PR branch lambros.petrou/integrate-e2e-system-tests with baseline commit 5b41544 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@lambrospetrou lambrospetrou force-pushed the lambros.petrou/integrate-e2e-system-tests branch from 1180e19 to 86c1737 Compare March 8, 2023 17:29
@lambrospetrou lambrospetrou marked this pull request as ready for review March 9, 2023 11:11
@lambrospetrou lambrospetrou requested a review from a team as a code owner March 9, 2023 11:11
@lambrospetrou lambrospetrou force-pushed the lambros.petrou/integrate-e2e-system-tests branch from 86c1737 to 69e1177 Compare March 9, 2023 14:14
@knusbaum knusbaum added this to the v1.49.0 milestone Mar 9, 2023
.github/workflows/system-tests.yml Outdated Show resolved Hide resolved
@lambrospetrou lambrospetrou force-pushed the lambros.petrou/integrate-e2e-system-tests branch from 69e1177 to c2b671b Compare March 9, 2023 14:41
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knusbaum knusbaum changed the title Integrate APM E2E tests in Github Actions CI .github/workflows: integrate APM E2E tests in Github Actions CI Mar 9, 2023
@knusbaum knusbaum merged commit 308285a into main Mar 9, 2023
@knusbaum knusbaum deleted the lambros.petrou/integrate-e2e-system-tests branch March 9, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants