Fix returned OS name on Linux

[albertvaka]

What does this PR do?

Fixes #1790

Additional notes

This might be a breaking change.

Reviewer's Checklist

• If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• Changed code has unit tests for its functionality.
• If this interacts with the agent in a new way, a system test has been added.

[pr-commenter]

Benchmarks

Comparing candidate commit fc363c1 in PR branch albertvaka/fix-linux-osname with baseline commit 308285a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

[nsrip-dd]

Good catch, thank you for the fix! I've confirmed that this looks good on a Linux box.

[albertvaka]

This fixes the code but I wonder if this could break queries that our customers already have. Is it okay to merge or should we wait until a major version bump?

[nsrip-dd]

Good question. Right now this value is only used in the tracer & profiler's startup logs. It's not attached as a tag to traces or metrics. I mainly see those logs as providing a quick set of information for support. From that POV this patch makes those logs strictly better. IMO this change is okay. But I suppose a customer could be basing a query off of those startup logs, and could care that the "os_name" value stays the same. Hyrum's law and all that.

I'll ping somebody from the tracer team for a second opinion.

[knusbaum]

This is mostly useful for debugging, along with all the other things Nick said. Fixing this will definitely be helpful for customers.

[albertvaka]

Okay, merging then!

[albertvaka]

Oh, it looks like I don't have permissions to merge.

[nsrip-dd]

Thanks @albertvaka!