Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/julienschmidt/httprouter: add http.route tag to span #1795

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

asdftamir
Copy link
Contributor

What does this PR do?

Add the http.route tag to the span

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented Mar 12, 2023

Benchmarks

Comparing candidate commit 34d0bf5 in PR branch tamir.hyman/add-http-route-to-julienschmidt with baseline commit 8c3e650 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 0 unstable metrics.

@asdftamir asdftamir marked this pull request as ready for review March 12, 2023 14:41
@asdftamir asdftamir requested a review from a team March 12, 2023 14:41
@asdftamir asdftamir changed the title contrib/julienschmidt/httprouter: add http.route tag to julienschmidt to span contrib/julienschmidt/httprouter: add http.route tag to span Mar 13, 2023
@zarirhamza zarirhamza added this to the v1.49.0 milestone Mar 22, 2023
Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good call on adding tests that aren't necessarily part of http.route but are necessary to maintain consistency across testcases

@zarirhamza zarirhamza merged commit a6e546c into main Mar 23, 2023
@zarirhamza zarirhamza deleted the tamir.hyman/add-http-route-to-julienschmidt branch March 23, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants